Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make statistic component support html role and data-* and aria-* attributes #47149

Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: make statistic component support html role and data-* and aria-* attributes #47149

merged 4 commits into from
Jan 26, 2024

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Jan 25, 2024 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Statistic component support html role and data-* and aria-* attributes
🇨🇳 Chinese Statistic 组件支持 HTML role、data-* 和 aria-* 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Visual Regression Report for PR #47149 Passed ✅

Target branch: master (aa137e9)

Congrats! No visual-regression diff found

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Preview Is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 331.29 KB (+79 B 🔺)
./dist/antd-with-locales.min.js 377.39 KB (+190 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 25, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5b5438:

Sandbox Source
antd reproduction template (forked) Configuration

@vagusX vagusX force-pushed the feat/statistic-support-html-attrs branch from 83ac100 to 5588dd1 Compare January 25, 2024 08:45
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1678d71) 100.00% compared to head (d5b5438) 100.00%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master    #47149    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          732       732            
  Lines        12553     12688   +135     
  Branches      3294      3352    +58     
==========================================
+ Hits         12553     12688   +135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jan 25, 2024

为啥 Table 截图会挂。

@vagusX
Copy link
Member Author

vagusX commented Jan 26, 2024

commits

是 rc 系列升级了嘛？我看应该不止这个 pr 会挂了，rebase 后应该就好了

@vagusX vagusX changed the title feat: make statistic component support html attributes feat: make statistic component support html role and data-* and aria-* attributes Jan 26, 2024
@zombieJ zombieJ merged commit 2aca1ff into master Jan 26, 2024
112 checks passed
@zombieJ zombieJ deleted the feat/statistic-support-html-attrs branch January 26, 2024 07:27
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@afc163 afc163 mentioned this pull request Jan 27, 2024
Merged
MadCcc pushed a commit that referenced this pull request Jan 29, 2024
@vagusX @MadCcc
feat: make statistic component support html role and data-* and aria-…
e83f08c 
…* attributes (#47149)

* feat: make statistic component support html attributes

* fix: types

* chore: improve

* feat: use pickAttrs for data-* and aria-* and role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@afc163 afc163 afc163 approved these changes

@MadCcc MadCcc Awaiting requested review from MadCcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vagusX @afc163 @zombieJ