Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drawer support passing aria-* to panel #47387

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 7, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/drawer#425

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Drawer supports passing aria-* to panel node.
🇨🇳 Chinese Drawer 现在支持传递 aria-* 属性给 panel 节点。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 7, 2024

👁 Visual Regression Report for PR #47387 Passed ✅

🎯 Target branch: master (a4c4c47)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-drawer@7.1.0 Transitive: environment +12 5.62 MB
npm/rc-table@7.40.0 Transitive: environment +14 6.22 MB afc163, benjycui, dxq613, ...6 more

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.45 KB (+60 B 🔺)
./dist/antd-with-locales.min.js 379.25 KB (-113 B 🔽)

@afc163 afc163 changed the base branch from master to feature February 7, 2024 05:47
Copy link

codesandbox-ci bot commented Feb 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eb0dbf:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39e7bc5) 100.00% compared to head (5eb0dbf) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12594     12594           
  Branches      3299      3299           
=========================================
  Hits         12594     12594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit a149377 into feature Feb 7, 2024
114 checks passed
@afc163 afc163 deleted the feat/upgrade-drawer branch February 7, 2024 12:20
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants