Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography symbol height exceed line should also support ellipsis #47889

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 15, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #41861

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography config the ellipsis.symbol exceed the single line height will make ellipsis rows not correct issue.
🇨🇳 Chinese 修复 Typography 配置的 ellipsis.symbol 超出单行高度时,省略行数不正确的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 15, 2024

👁 Visual Regression Report for PR #47889 Failed ❌

🎯 Target branch: master (7884eba)
📖 View Full Report ↗︎

Image name Expected Actual Diff
typography-ellipsis-debug.compact.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff
typography-ellipsis-debug.compact.css-var.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff
typography-ellipsis-debug.dark.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff
typography-ellipsis-debug.dark.css-var.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff
typography-ellipsis-debug.default.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff
typography-ellipsis-debug.default.css-var.png master: 7884eba28e186cf90a119f9e97065fdfb1903f14 current: pr-47889 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 334.6 KB (+27 B 🔺)
./dist/antd-with-locales.min.js 380.47 KB (-108 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7884eba) to head (2a9616f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47889   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12663     12670    +7     
  Branches      3328      3330    +2     
=========================================
+ Hits         12663     12670    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 31ff625 into master Mar 15, 2024
113 of 114 checks passed
@zombieJ zombieJ deleted the fix-symbol-height branch March 15, 2024 05:56
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

afc163 pushed a commit that referenced this pull request Mar 16, 2024
#47889)

* fix: Typography with ellipsis of symbol height

* test: update snapshot
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
ant-design#47889)

* fix: Typography with ellipsis of symbol height

* test: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph自定义symbol省略时显示的行数不正确
2 participants