Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RangePicker missing arrow and RTL styles #49333

Merged
merged 20 commits into from
Jun 18, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 10, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

See full diff: react-component/picker@v4.5.0...v4.6.4

此处可以测试箭头和 rtl 的效果:https://preview-49333-ant-design.surge.sh/components/date-picker-cn#components-date-picker-demo-placement

📝 Changelog

Language Changelog
🇺🇸 English - Fix DatePicker.RangePicker/TimePicker.RangePicker's arrow is missing when placement is set to topRight or bottomRight.
- Address DatePicker accessibility issue with the toggle button lacking alternative text.
- Fix DatePicker.RangePicker broken style in rtl mode.
- Fix DatePicker.RangePicker picker="year" throws error when input end value first.
- 🇹🇷 Improve DatePicker tr_TR locales.
- Fix DatePicker.RangePicker resetting selected date on keyboard input.
🇨🇳 Chinese - 修复 DatePicker/TimePicker 的 RangePicker 在 placement 设置为 topRightbottomRight 时箭头丢失的问题。
- 修复 DatePicker 切换按钮缺失可访问性文本的问题。
- 修复 DatePicker.RangePicker 在 RTL 模式下的样式问题。
- 修复 DatePicker.RangePicker 年选择器先输入结束值会导致报错的问题。
- 🇹🇷 调整 DatePicker 的土耳其语言文案。
- 修复 DatePicker.RangePicker 键盘输入日期时已选日期重置的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jun 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

👁 Visual Regression Report for PR #49333 Passed ✅

🎯 Target branch: feature (9c91bdb)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Prepare preview

Copy link
Contributor

github-actions bot commented Jun 10, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 340.38 KB (-58 B 🔽)
./dist/antd-with-locales.min.js 389.5 KB (+2 B 🔺)

@afc163 afc163 changed the title bump rc-picker fix: RangePicker missing arrow Jun 10, 2024
@afc163 afc163 marked this pull request as ready for review June 10, 2024 08:34
Copy link

socket-security bot commented Jun 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-picker@4.6.4-0 None 0 0 B

🚮 Removed packages: npm/rc-picker@4.5.0

View full report↗︎

li-jia-nan
li-jia-nan previously approved these changes Jun 11, 2024
@afc163 afc163 marked this pull request as draft June 11, 2024 01:31
@afc163
Copy link
Member Author

afc163 commented Jun 11, 2024

箭头位置还有问题。

图片

package.json Outdated Show resolved Hide resolved
Signed-off-by: afc163 <afc163@gmail.com>
Copy link

socket-security bot commented Jun 11, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/rc-picker@4.6.4-0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: afc163 <afc163@gmail.com>
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (9c91bdb) to head (3e3f98e).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature   #49333   +/-   ##
========================================
  Coverage    99.99%   99.99%           
========================================
  Files          750      750           
  Lines        13132    13132           
  Branches      3443     3443           
========================================
  Hits         13131    13131           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
Signed-off-by: afc163 <afc163@gmail.com>
@afc163
Copy link
Member Author

afc163 commented Jun 18, 2024

@SocketSecurity ignore-all

package.json Outdated Show resolved Hide resolved
Signed-off-by: afc163 <afc163@gmail.com>
@afc163 afc163 marked this pull request as ready for review June 18, 2024 10:37
package.json Outdated Show resolved Hide resolved
Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
Signed-off-by: afc163 <afc163@gmail.com>
@afc163 afc163 merged commit fad1497 into feature Jun 18, 2024
73 checks passed
@afc163 afc163 deleted the fix/date-picker-bugs branch June 18, 2024 15:59
MadCcc pushed a commit that referenced this pull request Jun 20, 2024
* bump rc-picker

* chore: update snapshot

* chore: update snapshot

* fix: arrow style

* fix: arrow transition style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* fix: rtl style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* fix rtl style

* chore: update snapshot

* fix rtl style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
@afc163 afc163 changed the title fix: RangePicker missing arrow fix: RangePicker missing arrow and RTL styles Jul 1, 2024
@afc163 afc163 mentioned this pull request Jul 1, 2024
@C3maLi
Copy link

C3maLi commented Jul 18, 2024

@afc163
Following the implementation of this PR, the Turkish date formats are not displaying correctly.
For further details, please see the related issue: #49956

madocto pushed a commit to madocto/ant-design that referenced this pull request Sep 11, 2024
* bump rc-picker

* chore: update snapshot

* chore: update snapshot

* fix: arrow style

* fix: arrow transition style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* fix: rtl style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* fix rtl style

* chore: update snapshot

* fix rtl style

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Update package.json

Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants