-
-
Notifications
You must be signed in to change notification settings - Fork 50k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RangePicker missing arrow and RTL styles #49333
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #49333 Passed ✅
🎊 Congrats! No visual-regression diff found. |
size-limit report 📦
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/rc-picker@4.5.0 |
4c34bb8
to
eaf6bae
Compare
Signed-off-by: afc163 <afc163@gmail.com>
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Signed-off-by: afc163 <afc163@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #49333 +/- ##
========================================
Coverage 99.99% 99.99%
========================================
Files 750 750
Lines 13132 13132
Branches 3443 3443
========================================
Hits 13131 13131
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: afc163 <afc163@gmail.com>
@SocketSecurity ignore-all |
Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com>
* bump rc-picker * chore: update snapshot * chore: update snapshot * fix: arrow style * fix: arrow transition style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix: rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix rtl style * chore: update snapshot * fix rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
* bump rc-picker * chore: update snapshot * chore: update snapshot * fix: arrow style * fix: arrow transition style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix: rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix rtl style * chore: update snapshot * fix rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
DatePicker
TimePicker
的RangePicker
在placement
设置为topRight
或bottomRight
时箭头丢失 #34501💡 Background and solution
See full diff: react-component/picker@v4.5.0...v4.6.4
此处可以测试箭头和 rtl 的效果:https://preview-49333-ant-design.surge.sh/components/date-picker-cn#components-date-picker-demo-placement
📝 Changelog
placement
is set totopRight
orbottomRight
.- Address DatePicker accessibility issue with the toggle button lacking alternative text.
- Fix DatePicker.RangePicker broken style in rtl mode.
- Fix DatePicker.RangePicker
picker="year"
throws error when input end value first.- 🇹🇷 Improve DatePicker tr_TR locales.
- Fix DatePicker.RangePicker resetting selected date on keyboard input.
placement
设置为topRight
或bottomRight
时箭头丢失的问题。- 修复 DatePicker 切换按钮缺失可访问性文本的问题。
- 修复 DatePicker.RangePicker 在 RTL 模式下的样式问题。
- 修复 DatePicker.RangePicker 年选择器先输入结束值会导致报错的问题。
- 🇹🇷 调整 DatePicker 的土耳其语言文案。
- 修复 DatePicker.RangePicker 键盘输入日期时已选日期重置的问题。
☑️ Self-Check before Merge