Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues in imageTest.tsx #49826

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix: issues in imageTest.tsx #49826

merged 2 commits into from
Jul 12, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jul 11, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

移除已弃用的 crypto@1.0.1 包,因为其已成为 Node 的一个内置模块
修复 imageTest.tsx 中的问题

Removed deprecated crypto@1.0.1, It's now a built-in Node module
Fix issues in imageTest.tsx

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: ant.design/changelog
Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

Copy link

stackblitz bot commented Jul 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Jul 11, 2024

👁 Visual Regression Report for PR #49826 Passed ✅

🎯 Target branch: master (b182b13)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

pkg-pr-new bot commented Jul 11, 2024

commit: 4b511e1

antd

npm i https://pkg.pr.new/ant-design/ant-design/antd@49826


templates

afc163
afc163 previously approved these changes Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (b182b13) to head (4b511e1).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #49826      +/-   ##
==========================================
- Coverage   99.99%   99.99%   -0.01%     
==========================================
  Files         748      748              
  Lines       13147    13057      -90     
  Branches     3452     3405      -47     
==========================================
- Hits        13146    13056      -90     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Jul 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/crypto@1.0.1

View full report↗︎

Copy link

socket-security bot commented Jul 11, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@afc163
Copy link
Member

afc163 commented Jul 12, 2024

@SocketSecurity ignore npm/sharp@0.33.4
@SocketSecurity ignore npm/puppeteer@22.13.0

@afc163 afc163 merged commit 1d84cca into ant-design:master Jul 12, 2024
49 checks passed
@RubuJam RubuJam deleted the fix/deps branch July 12, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants