Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown menu item get wrapped at edge #49899

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 16, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48620

💡 Background and solution

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: https://ant.design/changelog
Language Changelog
🇺🇸 English Fix Dropdown menu item wrong wrap style at edge of viewport.
🇨🇳 Chinese 修复 Dropdown 菜单内容在视口边缘换行的问题。

Copy link

stackblitz bot commented Jul 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

👁 Visual Regression Report for PR #49899 Failed ❌

🎯 Target branch: master (88c629e)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
breadcrumb-withParams.compact.css-var.png breadcrumb-withParams.compact.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
breadcrumb-withParams.compact.png breadcrumb-withParams.compact.png 🆕🆕🆕 Added 🆕🆕🆕
breadcrumb-withParams.dark.css-var.png breadcrumb-withParams.dark.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
breadcrumb-withParams.dark.png breadcrumb-withParams.dark.png 🆕🆕🆕 Added 🆕🆕🆕
breadcrumb-withParams.default.css-var.png breadcrumb-withParams.default.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
breadcrumb-withParams.default.png breadcrumb-withParams.default.png 🆕🆕🆕 Added 🆕🆕🆕

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Jul 16, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 342.47 KB (-40 B 🔽)
./dist/antd-with-locales.min.js 392.79 KB (-24 B 🔽)

Copy link

pkg-pr-new bot commented Jul 16, 2024

commit: c9cf7e0

antd

npm i https://pkg.pr.new/ant-design/ant-design/antd@49899


templates

@crazyair
Copy link
Member

体积大了好多。

@li-jia-nan
Copy link
Member

这也能大……

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (ca66d5c) to head (c9cf7e0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #49899   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         749      749           
  Lines       13063    13063           
  Branches     3405     3405           
=======================================
  Hits        13062    13062           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member Author

afc163 commented Jul 16, 2024

这也能大?

@crazyair crazyair merged commit acf73c9 into master Jul 16, 2024
77 checks passed
@crazyair crazyair deleted the fix/dropdown-menu-wrap branch July 16, 2024 20:13
@PeachScript PeachScript mentioned this pull request Jul 19, 2024
16 tasks
afc163 added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown 下拉菜单,带Icon,Children,弹出错位
3 participants