Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: we can skip a single file uploading error when uploading a folder… #50108

Merged

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Jul 27, 2024

… in scripts/visual-regression/upload.js

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: https://ant.design/changelog
Language Changelog
🇺🇸 English ----
🇨🇳 Chinese ----

Copy link

stackblitz bot commented Jul 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Jul 27, 2024

👁 Visual Regression Report for PR #50108 Passed ✅

🎯 Target branch: master (f56fee1)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@vagusX vagusX requested a review from kiner-tang July 27, 2024 08:26
li-jia-nan
li-jia-nan previously approved these changes Jul 27, 2024
@li-jia-nan
Copy link
Member

这个文件可以用 ts 写吗?

Copy link
Contributor

github-actions bot commented Jul 27, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 342.32 KB
./dist/antd-with-locales.min.js 394.62 KB

Copy link

pkg-pr-new bot commented Jul 27, 2024

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (cd4199e) to head (a7fc6cb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #50108   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         746      746           
  Lines       12918    12958   +40     
  Branches     3371     3385   +14     
=======================================
+ Hits        12917    12957   +40     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagusX vagusX merged commit 6202187 into master Jul 27, 2024
77 checks passed
@vagusX vagusX deleted the ci/upload-js-upload-folder-can-skip-single-file-upload-error branch July 27, 2024 08:58
linxianxi pushed a commit to linxianxi/ant-design that referenced this pull request Aug 14, 2024
ant-design#50108)

* ci: we can skip a single file uploading error when uploading a folder in scripts/visual-regression/upload.js

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants