-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: ColorPicker reset logic #50148
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #50148 Failed ❌
Check Full Report for details If you think the visual diff is acceptable, please check:
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rc-component/color-picker@1.5.3, npm/rc-input-number@9.1.0, npm/rc-input@1.5.1, npm/rc-mentions@2.14.0, npm/rc-slider@10.6.2, npm/rc-textarea@1.7.0 |
size-limit report 📦
|
commit:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #50148 +/- ##
===========================================
- Coverage 99.99% 99.99% -0.01%
===========================================
Files 753 751 -2
Lines 13821 13135 -686
Branches 3658 3426 -232
===========================================
- Hits 13820 13134 -686
Misses 1 1 ☔ View full report in Codecov by Sentry. |
feature 分支的 commit 带过来了 |
thx,我搞错基线了 |
大了 4.27kb 是合理的吗 |
哦,不对,这个应该是上一个提交的 size,最新的还没跑出来 |
看起来是没有更新,不过你看看代码。相信这个尺寸是误报吧。2333 |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
resolve #50127
💡 Background and solution
当从
transparent
切换到实色时,优先填充一个 hsb filled 色值以提升用户体验。📝 Changelog
transparent
state, it defaults to using a bright color instead of black color to enhance the user interaction experience.transparent
状态进行颜色选取时,默认使用亮色以代替原本的纯黑色以提升用户交互体验。