-
-
Notifications
You must be signed in to change notification settings - Fork 50k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Upload): should support name
prop drilling
#50652
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #50652 Passed ✅
🎊 Congrats! No visual-regression diff found. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/rc-upload@4.7.0 |
要作为 feature 么? @afc163 |
size-limit report 📦
|
More templates
commit: |
Deploying ant-design with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #50652 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 762 762
Lines 13497 13497
Branches 3507 3507
=========================================
Hits 13497 13497 ☔ View full report in Codecov by Sentry. |
对,作为 feature。 |
就这个 pr 改目标分支吧,等一波 ci 看看 |
name
prop
name
propname
prop
05243ce
to
bfb9a39
Compare
name 本来就支持,不用作为 feature ,当作一个 bug 修复,我在这里解释了一下 react-component/upload#576 (comment) |
name
propname
prop drilling
感觉还是得改成 feature 分支合适... (就这样定吧,有问题方便回滚) |
bfb9a39
to
822d8c4
Compare
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
fix: #50643
💡 Background and Solution
📝 Change Log
<Upload />
support 'name' prop drillingname
prop 透传