Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Layout.Sider content overflow when collapsedWidth={0} #52862

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 18, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

close #52674
close #52853

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

之前的一系列改动让

'> *': {
overflow: 'hidden',
},
失效了。

📝 Change Log

Language Changelog
🇺🇸 English Fix Layout.Sider content overflow issue when collapsedWidth={0}.
🇨🇳 Chinese 修复 Layout.Sider 当 collapsedWidth={0} 时的内容溢出的问题。

Copy link

stackblitz bot commented Feb 18, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 18, 2025

👁 Visual Regression Report for PR #52862 Passed ✅

🎯 Target branch: master (e7b0a9c)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size
dist/antd.min.js 447.57 KB (+4 B 🔺)
dist/antd-with-locales.min.js 533.23 KB (+6 B 🔺)

Copy link

codecov bot commented Feb 18, 2025

Bundle Report

Changes will increase total bundle size by 38 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB 38 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 19 bytes 1.84MB 0.0%
antd.min.js 19 bytes 1.54MB 0.0%

Copy link

pkg-pr-new bot commented Feb 18, 2025

@afc163 afc163 force-pushed the fix/layout-sider-overflow branch from 1ceac97 to 48a1781 Compare February 18, 2025 03:00
Copy link

cloudflare-workers-and-pages bot commented Feb 18, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: a218db8
Status: ✅  Deploy successful!
Preview URL: https://3c28f269.ant-design.pages.dev
Branch Preview URL: https://fix-layout-sider-overflow.ant-design.pages.dev

View logs

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e7b0a9c) to head (a218db8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #52862   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          767       767           
  Lines        13846     13846           
  Branches      3628      3628           
=========================================
  Hits         13846     13846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 70ccc04 into master Feb 18, 2025
45 checks passed
@afc163 afc163 deleted the fix/layout-sider-overflow branch February 18, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants