feat: update

ant-design · Jan 3, 2020 · 38ef479 · 38ef479
1 parent e699122
commit 38ef479
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/transforms/__tests__/v3-component-with-string-icon-props-to-v4.test.js b/transforms/__tests__/v3-component-with-string-icon-props-to-v4.test.js
@@ -9,11 +9,11 @@ jest.mock('../v3-component-with-string-icon-props-to-v4', () => {
 
 const tests = [
   'avatar',
-  // 'button',
-  // 'result',
-  // 'forked-avatar',
-  // 'forked-button',
-  // 'forked-result',
+  'button',
+  'result',
+  'forked-avatar',
+  'forked-button',
+  'forked-result',
 ];
 
 const defineTest = require('jscodeshift/dist/testUtils').defineTest;

diff --git a/transforms/utils/summary.js b/transforms/utils/summary.js
@@ -43,8 +43,17 @@ function cleanup() {
   fs.unlinkSync(summaryFilePath);
 }
 
+function addIconRelatedMsg(file, location, source) {
+  return appendLine(
+    `${file.path} - ${location.line}:${location.column}`,
+    source,
+    'Contains an invalid icon, please check it at https://ant.design/components/icon',
+  );
+}
+
 module.exports = {
   start,
   appendLine,
   output,
+  addIconRelatedMsg,
 };
diff --git a/transforms/v3-component-with-string-icon-props-to-v4.js b/transforms/v3-component-with-string-icon-props-to-v4.js
@@ -4,6 +4,7 @@ const {
   addSubmoduleImport,
 } = require('./utils');
 const { printOptions } = require('./utils/config');
+const { addIconRelatedMsg } = require('./utils/summary');
 const {
   createIconJSXElement,
   getV4IconComponentName,
@@ -78,13 +79,8 @@ module.exports = (file, api, options) => {
                 return;
               } else {
                 const location = path.node.loc.start;
-                const message =
-                  'Contains an invalid icon, please check it at https://ant.design/components/icon';
-                summary.appendLine(
-                  `${file.path} - ${location.line}:${location.column}`,
-                  j(nodePath).toSource(),
-                  message,
-                );
+
+                addIconRelatedMsg(file, location, j(nodePath).toSource());
               }
             }