Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove globby detection #76

Merged
merged 1 commit into from
Mar 2, 2020
Merged

feat: remove globby detection #76

merged 1 commit into from
Mar 2, 2020

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Mar 2, 2020

  • 移除 globby 嗅探，避免由于 node_modules 导致的卡死
  • 优化提示文案，将 install 和 update 分开

image

@vagusX vagusX requested a review from zombieJ March 2, 2020 13:02
@vagusX vagusX merged commit 9f99946 into master Mar 2, 2020
@vagusX vagusX deleted the feat/remove-globby-detect branch March 2, 2020 13:11
@afc163
Copy link
Member

afc163 commented Mar 3, 2020

没移除干净：

codemod-v4/transforms/utils/icon.js

Line 2 in cba7749

const globby = require('globby');

@vagusX vagusX mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vagusX @afc163