Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #8194 useEffect -> useLayoutEffect #8894

Closed
wants to merge 2 commits into from
Closed

fix: fix #8194 useEffect -> useLayoutEffect #8894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32e11c5
fix: fix #8194 useEffect -> useLayoutEffect
drizzlesconsin Nov 27, 2024
ec01176
chore: import useLayoutEffect
drizzlesconsin Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/layout/src/components/PageContainer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from 'antd';
import classNames from 'classnames';
import type { ReactNode } from 'react';
import React, { useContext, useEffect, useMemo } from 'react';
import React, { useContext, useLayoutEffect, useMemo } from 'react';
import { RouteContext } from '../../context/RouteContext';
import type { WithFalse } from '../../typing';
import type { FooterToolbarProps } from '../FooterToolbar';
Expand Down Expand Up @@ -352,7 +352,7 @@ const PageContainerBase: React.FC<PageContainerProps> = (props) => {
} = props;
const value = useContext(RouteContext);
/** 告诉 props 是否存在 footerBar */
useEffect(() => {
useLayoutEffect(() => {
if (!value || !value?.setHasPageContainer) {
return () => {};
}
Expand Down
Loading