Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion not working with custom PowerShell Editor Services #104

Closed
ivanskorikov opened this issue May 15, 2023 · 5 comments · Fixed by #156
Closed

Completion not working with custom PowerShell Editor Services #104

ivanskorikov opened this issue May 15, 2023 · 5 comments · Fixed by #156
Assignees
Labels
bug Something isn't working

Comments

@ivanskorikov
Copy link

Using JetBrains Rider.

Whatever version is loaded via File | Settings | Languages & Frameworks | PowerShell | PowerShell Editor Services, completion only shows keywords or locally defined functions. No PS library suggestion in completion.

Once I revert to the bundled PSES v 1.10.1, completion starts suggesting PS library functions.

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Oct 1, 2023

What version of PowerShellEditorServices are you trying to use? I'd like to note that so far we use a very old one 1.10.1, and upgrading it to the modern one may be very tricky.

Upgrade of the embedded PSES version is in our short-term plans (#51).

Perhaps sharing the IDE log would be useful in this case (since intellij-powershell v2.2.0 we now include the PSES log in the IDE log, so if there's a terminating error, then we'll see it).

@ForNeVeR ForNeVeR added bug Something isn't working status:waiting-for-info For issues that need additional information from the users labels Oct 1, 2023
@ivanskorikov
Copy link
Author

Blocked by #155

@ForNeVeR ForNeVeR added status:blocked Blocked on other issues and removed status:waiting-for-info For issues that need additional information from the users labels Oct 2, 2023
@ivanskorikov
Copy link
Author

Found a workaround for #155, so I've reproduced this with the latest plugin version and PSES v. 3.11.0
rider-logs-20231003-11550816257121191460710029.zip

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Oct 3, 2023

I see what's wrong now: we only attach our console listeners after we connect to the process and load the session file. This means that there will be no output and even no exit code if the session could not be found.

This is, of course, wrong, and leaves us without any diagnostics in this case.

This also explains the message PowerShell language host process exited: null: since we were unable to connect to the process, we haven't even assigned it into a variable, and thus weren't able to extract the exit code.

Diagnostic improvements are required.

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Oct 4, 2023

See my explanation in #156. I'm going to close this issue as partially fixed and partially a duplicate of #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants