Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PowerShell Core by default? #176

Closed
ForNeVeR opened this issue Nov 25, 2023 · 4 comments · Fixed by #249
Closed

Migrate to PowerShell Core by default? #176

ForNeVeR opened this issue Nov 25, 2023 · 4 comments · Fixed by #249
Assignees
Labels
enhancement New feature or request

Comments

@ForNeVeR
Copy link
Collaborator

Currently, the plugin prefers classic PowerShell if both PowerShell and PowerShell Core are available (see com.intellij.plugin.powershell.ide.run.PSExecutionUtilKt#findPsExecutable).

We should figure out if we it's safe to migrate to Core version by default.

My opinion is that if a person has explicitly installed the Core version, then it's likely they did that for a reason and want to use it: otherwise, why would they install it?

@ForNeVeR ForNeVeR added the enhancement New feature or request label Nov 25, 2023
@ForNeVeR ForNeVeR self-assigned this Nov 25, 2023
@andrewimcclement
Copy link

If it is decided that this isn't a good idea, an alternative would be to provide a setting for the default powershell path to use for scripts. (I'm assuming that this would be possible.) Of course, simply switching the default to PSCore is likely sufficient for most people, so that would be the simpler solution.

@ForNeVeR
Copy link
Collaborator Author

You can already switch the currently used PowerShell executable in the plugin settings. pwsh is expected to be fully supported, I use it myself. (Though I have to admit that my usage of script run configs may be lower than of some other features.)

@andrewimcclement
Copy link

Do you mean by editing the Run configuration template for PowerShell to point at the PSCore path? Or is there a more obvious setting somewhere? (I'm not entirely sure I know where to find the right settings).

@ForNeVeR
Copy link
Collaborator Author

ForNeVeR commented Jan 17, 2024

I mean this setting, PowerShell executable path:
image

Does it not work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants