Enable editing of ONVIF URL IP address via the Edit Broadcast dialog #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastpeony
force-pushed
the
onvifUrlSaveFix
branch
from
f8850ac
to
420f8b5
Compare
|
Hi @lastpeony , Thank you for the fix. I just need some clarity about this PR. I think something in the UI is confusing and it leads to further confusion. Generally, the expectation is to connect to the IP Camera through it's ONVIF address and get the stream URL from the IP Camera automatically. With this development, ONVIF address and stream URL ar changing independently. I just need some clarity to proceed with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, any changes made to the IP address of an ONVIF camera during editing were not saved, and the old IP address was consistently used. With this update, if it is possible to establish a connection to the camera using the new IP address, it will be saved and utilized.