Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tb/doc edits #4831

Merged
merged 11 commits into from
Mar 2, 2023
Merged

Tb/doc edits #4831

merged 11 commits into from
Mar 2, 2023

Conversation

timantmedia
Copy link
Contributor

@timantmedia timantmedia commented Feb 21, 2023

No description provided.

@timantmedia
Copy link
Contributor Author

@mustafaboleken Do you know why this failed in Travis? I cannot figure it out.

@timantmedia
Copy link
Contributor Author

@mustafaboleken The travis PR listed here seems to be successful https://app.travis-ci.com/github/ant-media/Ant-Media-Server/pull_requests

@mustafaboleken
Copy link
Contributor

@mustafaboleken Do you know why this failed in Travis? I cannot figure it out.

I just get updates from master, if it fails again, I will check and tell you the reason @timantmedia

@mustafaboleken
Copy link
Contributor

@timantmedia one of the test failed but it's not related with you, we can ignore this one

@mekya
Copy link
Contributor

mekya commented Mar 2, 2023

I've fixed the failing test and update this branch. So it's passing and merging for you.

Btw, what's Tb/doc means? @timantmedia

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mekya mekya merged commit 79d5130 into master Mar 2, 2023
@mekya mekya deleted the tb/doc-edits branch March 2, 2023 10:41
@timantmedia
Copy link
Contributor Author

I've fixed the failing test and update this branch. So it's passing and merging for you.

Btw, what's Tb/doc means? @timantmedia

@mekya I just created my own branch using the format initials Tb (Tim Bobker) and then the reason for the branch (docs) just so I can find it and list all my branches if I create another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants