Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis Support to Application Creation #5461

Merged
merged 27 commits into from
Mar 18, 2024
Merged

Add Redis Support to Application Creation #5461

merged 27 commits into from
Mar 18, 2024

Conversation

muratugureminoglu
Copy link
Collaborator

@muratugureminoglu muratugureminoglu commented Aug 14, 2023

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Mohit-3196 Mohit-3196 self-requested a review August 25, 2023 09:12
Copy link
Contributor

@Mohit-3196 Mohit-3196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
I was able to create applications with redis

@Mohit-3196
Copy link
Contributor

There are some missing parts for the Redis case specifically. Please do not merge it yet.

@muratugureminoglu
Copy link
Collaborator Author

Need to add the following line to dbtype.

if(isCluster) {
String mongoHost = getDataStoreFactory().getDbHost();
String mongoUser = getDataStoreFactory().getDbUser();
String mongoPass = getDataStoreFactory().getDbPassword();

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

sonarcloud bot commented Mar 18, 2024

@mekya mekya changed the title Add Redis support Add Redis Support to Application Creation Mar 18, 2024
@mekya mekya merged commit 128fb76 into master Mar 18, 2024
3 checks passed
@mekya mekya deleted the add_redis_support branch March 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants