Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTMP timestamp overflow after 24 days of non-stop streaming #6559

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony requested a review from mekya August 6, 2024 13:17
@mekya
Copy link
Contributor

mekya commented Aug 27, 2024

Hi @lastpeony ,

Thank you for the fix. I just made simple refactor.

Here is a quick trick. If you use setpts filter, it makes you reproduce the problem in a couple of seconds ;)

ffmpeg -stream_loop -1 -re -i src/test/resources/test_video_360p.flv -an -filter_complex "setpts=PTS+21474836/TB" -vcodec libx264 -profile:v baseline -f flv rtmp://localhost/live/stream1

Cheers
Oguz

Copy link

Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @lastpeony

I just made some quick refactors.

I've also added a quick way in the comment how to reproduce the problem faster.

FYI

@mekya mekya merged commit 141e1a2 into master Aug 28, 2024
9 checks passed
@mekya mekya deleted the fixRtmpDtsOverflow branch August 28, 2024 06:06
@mekya mekya changed the title Fix rtmp dts overflow Fix RTMP timestamp overflow after 24 days of non-stop streaming Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants