Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mp4 upload To S3 #6955

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Fix Mp4 upload To S3 #6955

merged 9 commits into from
Jan 20, 2025

Conversation

USAMAWIZARD
Copy link
Contributor

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was linked to issues Jan 20, 2025
MP4 files are uploading to the blank subfolder (/) in the AWS S3 bucket (AMS v2.12). #6927
Closed
MP4 files not uploading to the Google Cloud Storage bucket in v2.12 #6926
Closed
mekya
mekya approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @USAMAWIZARD

Thank you for the fix and test code 👏

Cheers
Oguz

@mekya mekya merged commit 5be413b into master Jan 20, 2025
9 checks passed
@mekya mekya deleted the mp4-s3upload-fix branch January 20, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ant Media Server
Status: ✅ Done
Milestone
No milestone
2 participants
@USAMAWIZARD @mekya