Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade electron #805

Merged
merged 5 commits into from
May 26, 2024
Merged

Conversation

mangas
Copy link
Contributor

@mangas mangas commented May 17, 2024

Would be great to upgrade to a newer version of electron so we can use the following on wayland

https://www.electronjs.org/docs/latest/api/environment-variables#electron_ozone_platform_hint-linux

@mangas
Copy link
Contributor Author

mangas commented May 17, 2024

I don't really know my way around the repo so if there's something missing test or upgrade wise let me know

@Fabio286 Fabio286 changed the base branch from master to develop May 20, 2024 07:33
@Fabio286 Fabio286 added the dependencies Pull requests that update a dependency file label May 20, 2024
@Fabio286
Copy link
Member

There is a need to test if the whole build system is working properly and if there are breaking changes.
I'll do some testing but there shouldn't be any major problems with the update though.

@mangas
Copy link
Contributor Author

mangas commented May 21, 2024

Thanks @Fabio286 let me know if I can help with anything

@Fabio286
Copy link
Member

I tried your PR and i have some issues running Antares. I have to go deeper and check electron breaking changes after version 26.

@Fabio286
Copy link
Member

Ok, issues disappeared updating @electron/remote to latest.

@Fabio286 Fabio286 merged commit 3fa9873 into antares-sql:develop May 26, 2024
@Fabio286
Copy link
Member

@all-contributors add @mangas for code

Copy link
Contributor

@Fabio286

I've put up a pull request to add @mangas! 🎉

@mangas mangas deleted the upgrade-electron branch May 26, 2024 15:30
@mangas
Copy link
Contributor Author

mangas commented May 26, 2024

awesome! thanks for checking 🙌

@Fabio286 do you mind tagging a release so we can use this on flathub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants