Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Search does not respect location/file exclusion pattern #6

Open
igorpupkinable opened this issue Mar 27, 2019 · 3 comments · Fixed by #7
Open

Search does not respect location/file exclusion pattern #6

igorpupkinable opened this issue Mar 27, 2019 · 3 comments · Fixed by #7

Comments

@igorpupkinable
Copy link

If you specify search location as gatsby, !data then gatsby\data directory is not excluded from search. It does work in Atom's built-in find-and-replace however.
It would be good to add this functionality.

I am using Atom v1.34.0 x64 on Windows 10 Pro x64 with atom-codesearch v1.3.0.
lacostenycoder added a commit to lacostenycoder/atom-codesearch that referenced this issue Apr 27, 2019
@lacostenycoder
default search to project path
6fb488d 
Fix antelle#6

This fixes bug which gave no results unless you enter . in the path to
search. Working with the_platinum_searcher. the_silver_searcher was at
this point already broken.
lacostenycoder added a commit to lacostenycoder/atom-codesearch that referenced this issue Apr 27, 2019
@lacostenycoder
default search to project path
1859c05 
Fix antelle#6

This fixes bug which gave no results unless you enter . in the path to
search. Working with the_platinum_searcher. the_silver_searcher was at
this point already broken.
@lacostenycoder lacostenycoder mentioned this issue Apr 27, 2019
Merged
@lacostenycoder
Copy link
Contributor

@antelle I think this was closed by accident, this is still broken. I was about to start working on it. I think you meant to close #5

@antelle antelle reopened this Apr 28, 2019
@antelle
Copy link
Owner

antelle commented Apr 28, 2019

This was closed automatically because you mentioned #6 in the MR. Reopened it again, thanks.

@lacostenycoder
Copy link
Contributor

oops my bad, ok no problem. I'll see what I can do with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default search to project path lacostenycoder/atom-codesearch
3 participants
@antelle @igorpupkinable @lacostenycoder