Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Deno as package manager #21

Closed
3 tasks done
MichaelDeBoey opened this issue Oct 14, 2024 · 3 comments · Fixed by #25
Closed
3 tasks done

Add support for Deno as package manager #21

MichaelDeBoey opened this issue Oct 14, 2024 · 3 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@MichaelDeBoey
Copy link
Contributor

Clear and concise description of the problem

Deno is now a package manager with deno install

Suggested solution

Update all public methods to be able to recognize Deno as well

Alternative

No response

Additional context

No response

Validations

@benmccann
Copy link
Collaborator

We might also have to add extra support specifically for Deno in getUserAgent added in #20 or try to implement support in Deno (denoland/deno#25342)

@Malix-Labs
Copy link

Malix-Labs commented Nov 1, 2024

@benmccann denoland/deno#25342 has just been closed 🚀

@birkskyum
Copy link

birkskyum commented Nov 1, 2024

In case it's helpful for you, if you don't see the agent (i got undefined). I've just looked at adding deno to the solidjs cli, and found the agent only show when deno executes a npm:package or a package.json script - see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants