feat: make long list scrollable for interactive mode #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
changed the title
antfu
approved these changes
Nov 27, 2023
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In interactive mode, if our terminal is too short or our deps are too many, we cannot see all deps.
When we use arrow keys to move the selection, the user experience is not good. Especially, when the selection is in the start part, everytime I move the selection, the terminal just scroll back to the bottom, and I can't see the selection anymore. So I have to drag to enlarge the terminal area. But what if our deps are so many that whole screen cannot embrace them or we just don't want to do the drag.
So I made the pr. The method I use is: only render a part of output lines if there is no enough space.
Linked Issues
There is no issue about this now. Feel free to reject this if you consider it not appropriate.