Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bun support #24

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Conversation

chrisbbreuer
Copy link
Contributor

Description

This PR adds support for Bun by not utilizing Jiti and letting Bun handle it.

Linked Issues

I started a Discord discussion on this topic a couple of days ago.

Additional context

mlly is a devDependency of jiti: https://github.com/unjs/jiti/blob/main/package.json#L61

otherwise it may trigger if we use node but bun as a package manager / script runner
src/index.ts Outdated
// FIXME: https://github.com/unjs/jiti/pull/141
requireCache: false,
})(bundleFilepath)
if (process.env.npm_execpath.includes('bun')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (process.env.npm_execpath.includes('bun')) {
if (process.versions.bun) {

vitejs/vite#13901

@antfu antfu merged commit 35bb58c into antfu-collective:main Jul 30, 2023
@chrisbbreuer chrisbbreuer deleted the feat/bun-support branch July 30, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants