fix: npm scripts not working on windows #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
changed the title
|
Emm, we can wrote a simple javascript to copy the files instead of using cli. |
antfu
reviewed
Jun 16, 2021
package.json
Outdated
| "example:store:dev": "cp README.md examples/multiple-pages-with-store/README.md && npm -C examples/multiple-pages-with-store run dev", | ||
| "example:store:build": "cp README.md examples/multiple-pages-with-store/README.md && npm -C examples/multiple-pages-with-store run build", | ||
| "example:store:serve": "cp README.md examples/multiple-pages-with-store/README.md && npm -C examples/multiple-pages-with-store run serve", | ||
| "copy-files": "node scripts/copy-files.ts", |
There was a problem hiding this comment.
Suggested change
| "copy-files": "node scripts/copy-files.ts", | |
| "copy-files": "esno scripts/copy-files.ts", |
antfu
reviewed
Jun 16, 2021
scripts/copy-files.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
| const fs = require('fs') | |||
There was a problem hiding this comment.
Using esno we could use import here
There was a problem hiding this comment.
we need to add esno to dev dependencies, you have it globally...
There was a problem hiding this comment.
F:\work\projects\quini\GitHub\antfu\vite-ssg>pnpm run example:dev
> vite-ssg@0.11.2 example:dev F:\work\projects\quini\GitHub\antfu\vite-ssg
> npm run copy-files && npm -C examples/multiple-pages run dev
> vite-ssg@0.11.2 copy-files
> esno scripts/copy-files.ts
"esno" no se reconoce como un comando interno o externo,
programa o archivo por lotes ejecutable.
ERROR Command failed with exit code 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53
Also includes
.idea/directory forintellij/webstormon.gitignorefile.