Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check packages existence in local scope #583

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

paescuj
Copy link
Contributor

@paescuj paescuj commented Aug 16, 2024

Description

  • Use explicit scope path for existence checks of ESLint/Prettier plugin deps
  • Skip installation of missing packages if current working directory is not in scope of @antfu/eslint-config

Linked Issues

Fixes #581

Additional context

  • The existence check for packages that aren't directly used, but just control the config (e.g. typescript) is not changed, as for those it makes sense to look in current working directory.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
🔨 Latest commit c3a6a72
🔍 Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/66bf3f9790643e00085b8fb8
😎 Deploy Preview https://deploy-preview-583--melodious-froyo-4871f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu changed the title fix: correct scope for existence check of plugin deps fix: check packages existence in local scope Aug 16, 2024
@antfu antfu merged commit 12fd868 into antfu:main Aug 16, 2024
8 checks passed
@paescuj paescuj deleted the fix/check-resolve-deps branch August 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope not considered when checking existence of ESLint/Prettier plugins
2 participants