Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Update for Vite 4.x support #16

Closed
3 tasks done
khalwat opened this issue Dec 9, 2022 · 1 comment · Fixed by #17
Closed
3 tasks done

[feat]: Update for Vite 4.x support #16

khalwat opened this issue Dec 9, 2022 · 1 comment · Fixed by #17
Labels
enhancement New feature or request

Comments

@khalwat
Copy link
Contributor

khalwat commented Dec 9, 2022

Clear and concise description of the problem

With Vite 4's released, it'd be great to update the peerDependencies to allow it to work with Vite 4.x (assuming no other changes are needed).

Suggested solution

PR to address the issue: #17

Update peerDependencies:

  "peerDependencies": {
    "vite": "^2.9.0 || ^3.0.0" || ^4.0.0"
  },

Alternative

No response

Additional context

No response

Validations

@khalwat khalwat added the enhancement New feature or request label Dec 9, 2022
@khalwat khalwat changed the title [feat]: Updated for Vite 4.x support [feat]: Update for Vite 4.x support Dec 9, 2022
khalwat added a commit to khalwat/vite-plugin-restart that referenced this issue Dec 9, 2022
@khalwat
Copy link
Contributor Author

khalwat commented Dec 10, 2022

In my limited testing, I can confirm that just bumping the peerDependencies appears to work fine with Vite 4.x

@antfu antfu closed this as completed in #17 Dec 13, 2022
antfu pushed a commit that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant