fix(pwa): dynamic hi
route and F5
#98
Open
+33
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
hi
route even when offline, if the entry is cached it will work (press F5 once entered a name and before going offline): a lot of work per dynamic routeIf the
/hi/<name>
route is not in thehi-id-cache
, thehandlerDidError
plugin will redirect to/
.EDIT: sometimes
useOnline
is not working, maybe some hydration/client problem, there is no warning/error.This will work only when using
build + start
scripts, usinggenerate + start:generate
scripts will not work since node/express will return 404 for the dynamic route and will not be cached.