fix: scroll positions not saving/restoring correctly when using browser back/forward buttons #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back/forward buttons When using browser nav the browser fires the popstate event. It fires this event before any of the router callbacks go off and it can't be intercepted, therefore we can't save scroll position before popstate fires. The other option is to not rely on events for saving scroll pos and instead just do it periodically. This fixes the popstate issue as well as components whose DOM updates before the router callbacks. Waiting too late could mean the element no longer exists or its size has changed.
Author
|
@antfu when you have a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using browser nav the browser fires the popstate event before any of the router callbacks go off, and it can't be intercepted. Therefore we can't rely on events to save the scroll position when using the back/forward buttons. This sets up an interval timer to periodically save the scroll position.
For more info see: #4 (comment)
Linked Issues
fixes #3
fixes #4
Additional context