Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add helm #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Add helm #3

wants to merge 3 commits into from

Conversation

zhuangzhuang131419
Copy link

@chenk008

Why are these changes needed?

Add a helm chart, deliver helm chart to other users who want to try Ray on their Kubernetes clusters.

Related issue number

ray-project#41 Add helm Chart

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@zhuangzhuang131419 zhuangzhuang131419 changed the title Add helm [WIP] Add helm Oct 26, 2021
@harryge00
Copy link

其实我觉得你可以把6个commit 合成1个。

git reset 898dc6ac4858855c8c242ae04d2209cd84729bda  #回退到第一个commit
git add .
git commit --amend #然后修改下内容 “Add helm”

@chenk008
Copy link
Collaborator

chenk008 commented Dec 3, 2021

helm/helm3 重命名为：helm-chart

@chenk008
Copy link
Collaborator

chenk008 commented Dec 3, 2021

helm/helm3/ray-cluster-helm/templates/NOTES.txt 这个文件没有用旧删掉

@chenk008
Copy link
Collaborator

chenk008 commented Dec 3, 2021

helm/helm3/ray-operator-helm/templates/NOTES.txt 也删掉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenk008 chenk008 chenk008 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuangzhuang131419 @harryge00 @chenk008