Merge remote-tracking branch 'upstream/master'

anthony-wang · Dec 18, 2020 · 3d874c5 · 3d874c5
2 parents 03f1e09 + a27e17d
commit 3d874c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/conda-env.yml b/conda-env.yml
@@ -6,7 +6,7 @@ dependencies:
   - python=3.7.*
   - numpy=1.18.*
   - pandas=1.0.*
-  - pandas-profiling=2.4.*
+  - pandas-profiling=2.8.*
   - matplotlib=3.2.*
   - seaborn=0.10.*
   - scikit-learn=0.22.*
@@ -15,4 +15,4 @@ dependencies:
   - cudatoolkit=10.*
   - tqdm=4.43.*
   - ipython
-  - jupyter
+  - jupyter
diff --git a/notebooks/CBFV/cbfv/composition.py b/notebooks/CBFV/cbfv/composition.py
@@ -290,10 +290,10 @@ def generate_features(df, elem_prop='oliynyk',
 
     # get the column names
     cols = X.columns.values
-    # find the mean value of each column
+    # find the median value of each column
     median_values = X[cols].median()
-    # fill the missing values in each column with the columns mean value
-    X[cols] = X[cols].fillna(median_values.iloc[0])
+    # fill the missing values in each column with the column's median value
+    X[cols] = X[cols].fillna(median_values)
     return X, y, formulae, skipped