Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required updates to support es 7.7 #1

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

spiritinlife
Copy link
Contributor

I am not sure about this part.

@Override
        public boolean isResultDeterministic() {
            // PositionRecipScript does not use deterministic APIs so that means that results
            // are not cachable? @todo
            return true;
        }

Related resources about this
elastic/elasticsearch#49466
https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-engine.html

Comment on lines +64 to +65
// PositionRecipScript does not use deterministic APIs so that means that results
// are not cachable? @todo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it is deterministic as it doesn't use any API like random.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y that was my understanding also. Lets remove the @todo comment then?

@anti-social anti-social merged commit fe05b46 into anti-social:master Apr 29, 2021
@anti-social
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants