-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle file detection in same directory broken in Windows #109
Comments
seanson
added a commit
to seanson/videogrep
that referenced
this issue
Jul 12, 2022
Fixes antiboredom#109 This swaps out the os.path methods for using pathlib instead in the subtitle detection function and test path generation. This helps mitigate Windows' weird behaviour with dirname returns on files in the same directory.
I get the same issue on macos.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running on a file in the same directory in Windows, the
os.path.dirname
returns''
, which fails withos.scandir
raising the errorFileNotFoundError: [WinError 3] The system cannot find the path specified: ''
Working in subdirectory:
Failing in same directory:
The text was updated successfully, but these errors were encountered: