fix windows esi compile #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regner
force-pushed
the
1-fix-windows-esi-compile
branch
from
129f3da to
0942c50
Compare
|
@antihax think this is good to go. If you want to test it you will need to remove the underscore from the ESI swagger URL as thats broken right now. The tests I ran locally came out good. |
|
I may have totally lied about everything... got home and went to do some work on my other project and I am still running into the same issue... but it worked last night after I ran this... so I am confused but will report back later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script that shortens the names of output ESI files. The script runs after all the build steps but before the tests.
Also ran
chmod +xon the two build scripts.Fixes antihax/goesi#1