Refactor #20
Merged
Refactor #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has given me the opportunity to review the safety of the unsafe code - and it was found lacking. But it's fixed in the plumbing module. #16 I've tried to not put naming opinions within the plumbing module. That is, things within it are named to match the c or c++ libraries of leptonica and tesseract as much as possible. This addresses #17 at least within the plumbing module.
I'm not sure what purpose it served
This gives users a chance to deal with errors, rather than having panics.
As pointed out in #18 it makes the API nicer. And I'm breaking the API anyway, in order to return result types, so I may as well make this further change.
This was
linked to
issues
May 29, 2020
|
I didn't look carefully at the FFI parts but the Rust API looks nice to use! The only question I have is, if it's mandatory to set a language, should the language string be passed into |
This was done by initializing on the call to new. This was suggested by the pull request #20 by @hdevalence. This may address #6, as we now expose datapath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses safety (f203642 #16)
And ergonomics (#17, #18, 6a1948f, ce8303c)
Please see the individual commits for more detail.