Fix for Issue 357, and allow choosing which db to sample #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(It was stubbed out and replaced with a hard-coded sample dataset!)
Without this you can't do redisCommand("SELECT %d", 4)
Merge branch 'fix-sample-dataset'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have a fix and an enhancement for redis-stat's database sampling code. The fix is for http://code.google.com/p/redis/issues/detail?id=357 (restores the sampling code from where it was commented out), and the enhancement is to allow specifying on the command line which database to sample, rather than forcing db 0.
(I'm not sure whether Github keeps subsequent pull requests separate, so this might also contain my earlier patch for adding AUTH support to redis-stat: http://github.com/antirez/redis-tools/pull/1)
Cheers,
Sam