Add textual signature to generated PDFs #1514
Conversation
There was a problem hiding this comment.
@ershad _a Could you have a look please? Here's a sample PDF:
| head :created | ||
| end | ||
|
|
||
| def signed |
There was a problem hiding this comment.
TRPC calls this endpoint to generate a PDF for the signed document.
| @@ -0,0 +1,108 @@ | |||
| <style> | |||
There was a problem hiding this comment.
We don't have Tailwind in PDFs. Also note that webfonts don't seem to work in this context, so the default sans and cursive fonts are used. This happens in share certificates too:
| await documentsFactory.create({ companyId: company.id, text: "Test document text" }); | ||
| const { user: recipient } = await usersFactory.create({ legalName: "Recipient 1" }); | ||
| await companyContractorsFactory.create({ companyId: company.id, userId: recipient.id }); | ||
| await companyContractorsFactory.create({ companyId: company.id, userId: recipient.id }, { withoutContract: true }); |
There was a problem hiding this comment.
Makes the below cleaner as otherwise the user already has a contract.
| .leftJoin(activeStorageBlobs, eq(activeStorageAttachments.blobId, activeStorageBlobs.id)) | ||
| .where(where) | ||
| .orderBy(desc(documents.id)); | ||
| .orderBy(desc(documents.id), desc(activeStorageAttachments.id)); |
There was a problem hiding this comment.
To match document.live_attachment.
|
|
||
| def active? = deactivated_at.nil? | ||
|
|
||
| def primary_admin = super || company_administrators.first |
There was a problem hiding this comment.
Falling back to the current behaviour if the field isn't set.
ershad
left a comment
ershad
left a comment
There was a problem hiding this comment.
@MayaRainer _a added a few comments, please take a look.
| end | ||
|
|
||
| def signed | ||
| document = Document.find(params[:id]) |
There was a problem hiding this comment.
to be safe -
| document = Document.find(params[:id]) | |
| document = Current.company.documents.find(params[:id]) |
| const response = await fetch(signed_company_document_url(ctx.company.externalId, document.documents.id), { | ||
| method: "POST", | ||
| headers: ctx.headers, | ||
| }); |
There was a problem hiding this comment.
When we make this API call, we are still inside the DB transaction, and the signedAt update hasn't been committed yet. Could be why I saw an empty field for contractor Date signed in the PDF when tested locally. But if the job is delayed for some reason, we won't see this issue. Could you please check? Ideally, we need to generate the doc outside the transaction.
| t.jsonb "json_data", default: {"flags" => []}, null: false | ||
| t.boolean "equity_enabled", default: false, null: false | ||
| t.string "invite_link" | ||
| t.bigint "primary_admin_id" |
There was a problem hiding this comment.
We need to add this to frontend/db/schema.ts as well?
|
|
||
| def active? = deactivated_at.nil? | ||
|
|
||
| def primary_admin = super || company_administrators.first |
There was a problem hiding this comment.
To be consistent with the previous behavior:
| def primary_admin = super || company_administrators.first | |
| def primary_admin = super || company_administrators.order(:id).first |
As per internal discussion, PDFs generated when signing documents should contain a textual signature of both parties. This PR adds that.