Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go runtime missing export of "Reset()" #3441

Closed
kaby76 opened this issue Dec 29, 2021 · 3 comments
Closed

Go runtime missing export of "Reset()" #3441

kaby76 opened this issue Dec 29, 2021 · 3 comments

Comments

@kaby76
Copy link
Contributor

kaby76 commented Dec 29, 2021 •
edited
Loading

Could the Go target (commonly referred to as "Golang" in order to appease web search engines) runtime be changed to export reset()? It's exported for the other runtimes, but Go requires an uppercased-first-letter func name in order for it to be visible.
@KvanTTT
Copy link
Member

KvanTTT commented Dec 29, 2021

Could you please suggest a PR?

@kaby76
Copy link
Contributor Author

kaby76 commented Dec 29, 2021

PR 3442

@kaby76 kaby76 changed the title Please export reset() in Go target (i.e., change reset() to Reset()) Go runtime missing export of "Reset()" Dec 30, 2021
kaby76 added a commit to kaby76/antlr4 that referenced this issue Feb 22, 2022
@kaby76
Fix for antlr#3441 and antlr#3443 -- expose Reset() and String() meth…
980a2de 
…ods.
This was referenced Feb 22, 2022
Draft
Draft
@kaby76
Copy link
Contributor Author

kaby76 commented Jul 2, 2023

This seems to have been fixed at some point. https://github.com/antlr/antlr4/blame/master/runtime/Go/antlr/v4/lexer.go#L122

@kaby76 kaby76 closed this as completed Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KvanTTT @kaby76