Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#, JavaScript, Go runtime tests performance improvements #3365

Merged
merged 7 commits into from
Nov 29, 2021

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented Nov 27, 2021

I've added compilation of C# runtime project before the test session. After that, each test use compiled assembly instead of referencing to .csproj and extra compilation.

For Node I've removed npm packaging and implemented referencing right on runtime files.

For Go I've added GOROOT redirecting and removed extra copying of runtime files on every test.

There is the table with optimization results:

Language Before After Ratio
C# 21 min 15 min 0.7
JavaScript 22 min 6 min 0.3
Go 20 min 8 min 0.4
All 88 min 55 min 0.63

Now runtime tests work much faster and use much less IO operations.

@KvanTTT KvanTTT marked this pull request as ready for review November 28, 2021 09:44
@KvanTTT KvanTTT force-pushed the csharp-runtime-tests-performance branch from 841d309 to eaed457 Compare November 28, 2021 12:53
@KvanTTT KvanTTT changed the title C# runtime tests performance improvements C# and JavaScript runtime tests performance improvements Nov 28, 2021
…y test run

It has significantly improved performance
@KvanTTT KvanTTT changed the title C# and JavaScript runtime tests performance improvements C#, JavaScript, Go runtime tests performance improvements Nov 28, 2021
@KvanTTT
Copy link
Member Author

KvanTTT commented Nov 28, 2021

It's strange that golang tests work on my Windows machine but don't work on CI machine. I'll investigate.

@KvanTTT KvanTTT force-pushed the csharp-runtime-tests-performance branch from 5d1e953 to 7a87cdc Compare November 28, 2021 21:50
@ericvergnaud ericvergnaud merged commit e811330 into antlr:master Nov 29, 2021
@KvanTTT KvanTTT deleted the csharp-runtime-tests-performance branch November 29, 2021 10:06
@KvanTTT
Copy link
Member Author

KvanTTT commented Nov 29, 2021

It's strange that this branch is green but master is red. There are failing dotnet and go tests on Linux. The problem with go is probably is outdated version. The problem with C# is incompatible target in .csproj but it seems I know how to fix it.

It would be great to show all tests for every branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants