Set version to 4.10 #3460
Set version to 4.10 #3460
Conversation
|
@parrt When v4.10 will be released as I really need the caseInsensitive option ? |
|
There are a lot of changes and improvements, some of them are still ongoing. Also, firstly I suggest publishing a release candidate to test it on our grammars repository. As a workaround, you can use CaseInsensitiveInputStream or |
|
I think we should shoot for a release within a month. What do you guys think? We can always do a quick release after that. Let's do all of the major stuff that is related to code generation now... |
|
Not sure, at least I would like to complete bad words escaping (it's still incomplete), issues related to code generation, and to test grammars from grammars-v4 on the new version. |
|
I’m all for frequent small (automated) releases
It reduces risk and encourages potential contributors
… Le 7 févr. 2022 à 18:40, Terence Parr ***@***.***> a écrit :
I think we should shoot for a release within a month. What do you guys think? We can always do a quick release after that. Let's do all of the major stuff that is related to code generation now...
—
Reply to this email directly, view it on GitHub <#3460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJBZNNY35HSZ6ET6Y3DUZ772HANCNFSM5LIGPHYQ>.
You are receiving this because you are subscribed to this thread.
|
|
Ok, I suggest at least completing all issues related to ATN serialization to stabilize the format before the next version releasing. |
|
I agree that's a good cut off point. Happy to take a look at your PR for reducing the size of generated ATN strings... |
|
@parrt Hi, is there any progress regarding the release of version 4.10? It has been a long time since the last release. |
|
Yes, I'm still waiting for your review and merge of #3513 |
|
ah! I didn't notice it was ready. Sorry! |
|
OK, thank you for your reply. Looking forward to your good news. |
|
Oh, @KvanTTT where are we at with regards to the PR to tweak the generated symbols if they are keywords? That would also be something good to get into a major revision such as 4.10. (working on your atn PR at the moment) |
|
looks like we are getting closer folks. I merged @KvanTTT's awesome ATN optimization yesterday. I would like to get a bit more testing done inside Google before we declare 4.10 ready, probably with a release candidate. Also, @KvanTTT remind me. We merged your groovy PR to avoid generating keywords in the generated code right? #3451 Is there anything else we need to do on? @kaby76 has also been working hard on keyword lists for a few more languages. I also have been working on fixing some issues in the intellij plug-in with more recent versions of the IDE; it would be nice to get 4.10 into that upcoming release as well. |
|
I also need to work on the release process haha...it's got to be quite a furball and some of that we can automate. I hope |
Yes, but the problem still is not completely resolved. But it's not critical and could be resolved in the next version.
I suggest reviewing another PR that breaks ATN serialization a bit but simplifies and expends it (there is no need to use |
|
Ok, so let's start moving towards 4.10 rc1. Can you guys @ericvergnaud @mike-lischke @KvanTTT @jcking check to see if there are any PRs that should sneak in for 4.10? |
|
Can someone state what the officially minimum requirements for PHP are? The instructions here and duplicated here say nothing. Many "reserved words" in the PHP list in the latest "dev" tool which I modified to remove all reserved words checks, do not cause a problem in and the generated parser works fine. For example, "break()" is a perfectly legal method name. Currently I have installed PHP 7.4.3 (cli) (built: Nov 25 2021 23:16:22) ( NTS ). #3451 |
|
Except for that last optimization patch from Justin I don't see anything for C++. |
|
@kaby76 does that mean we can reduce the size of the naughty words list for PHP? |
Probably yes, but I'm not sure about all words because some words conflict with internal members, not keywords. BTW, currently, there are no usages of |
|
Oh wow. haha. we should resolve this by either removing or starting to use it I guess. if it is currently working maybe we just stop using it in the template file. |
|
#3507 is awaiting proper performance testing
#3560 is WIP
#3547 is draft
#3229 is not progressing
#3205 is awaiting proper testing
…
in short, nothing ready to go
… Le 24 févr. 2022 à 02:14, Terence Parr ***@***.***> a écrit :
Ok, so let's start moving towards 4.10 rc1. Can you guys @ericvergnaud <https://github.com/ericvergnaud> @mike-lischke <https://github.com/mike-lischke> @KvanTTT <https://github.com/KvanTTT> @jcking <https://github.com/jcking> check to see if there are any PRs that should sneak in for 4.10?
—
Reply to this email directly, view it on GitHub <#3460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJHJFHFRBUWQDDVZXK3U4WA5RANCNFSM5LIGPHYQ>.
You are receiving this because you were mentioned.
|
|
okay thanks Eric. |
|
Ok, I will start the process and work on the release process as well. @jcking let's get last minute changes in this week if we can. |
|
Closing in favor of #3599 |
in prep for 4.10 release