Issue #3783: CI Check Builds #3792

hs-apotell · 2022-07-16T10:22:02Z

Issue #3783: CI Check Builds

Adding workflow for Github hosted CI check builds. Supports all three
supported platforms with all runtime languages except swift.

Also, includes cpp native builds across all supported platforms i.e.
independent on the test run builds.

Every configuration build generates an artifact (archive of the entire
repository) and is uploaded as a result of the build (regardless of
success or failure).

Signed-off-by: HS hs@apotell.com

Adding workflow for Github hosted CI check builds. Supports all three supported platforms with all runtime languages except swift. Also, includes cpp native builds across all supported platforms i.e. independent on the test run builds. Every congiguration build generates an artifact (archive of the entire repository) and is uploaded as a result of the build (regardless of success or failure). Signed-off-by: HS <hs@apotell.com>

ericvergnaud · 2022-07-16T10:43:44Z

Looks great: doesn't break self-hosted
What's in the way for also having swift ?

ericvergnaud · 2022-07-16T10:45:36Z

And let's find out how many free builds we get

parrt · 2022-07-16T16:17:52Z

@hs-apotell Amazing. Pulling in! I should merge that file into dev as well right so PRs and our dev gets tested?

parrt · 2022-07-16T16:18:11Z

Oh, it's in dev now. sorry. thanks!

KvanTTT

Is it also possible to include test for tool itself? (not runtime) See https://app.circleci.com/pipelines/github/antlr/antlr4/1885/workflows/cb672c7b-206e-4390-b823-0a3f6f6454da/jobs/20238 for instance.

.github/workflows/hosted.yml

KvanTTT · 2022-07-16T20:11:17Z

.github/workflows/hosted.yml

+      if: always()
+      run: |
+        cd ${{ github.workspace }}/..
+        tar czfp antlr_${{ matrix.os }}_${{ matrix.compiler }}.tgz antlr4


Is it possible to use more standard zip format instead of tgz?

I am not sure if the default VM image for all platforms have zip installed or not. Will have to investigate.

BTW, standard is very much platform dependent. On Windows, zip but on Posix it would be tar/tgz.

.github/workflows/hosted.yml

KvanTTT · 2022-07-16T20:22:31Z

Am I understand correctly that now CircleCI is not required at all since GitHub supports all OS.

hs-apotell · 2022-07-16T21:01:42Z

I would let the current change bake for about a week and follow up later with others (swift and tool).

I would like to fix all the compile warnings in native build and also update the builder and test runner to post the logs. If you can assist with the latter (it's Java code) that would be great.

parrt · 2022-08-13T17:54:48Z

Hi @hs-apotell it's getting confusing with all of the hosted versus Remote testing... It looks like it's more reliable hosted than remote. Could you check the actions and see if you concur? @ericvergnaud are you OK if we turn off the remote CI?

Something is screwy because some of the targets are now failing but it's hard to tell looking at all of the actions what's going on so I wanted to simplify. Seems we get a lot of timeouts from maven :(

parrt · 2022-08-13T18:24:37Z

(PS: i just tweaked to use 1.19 Go)

hs-apotell · 2022-08-13T18:59:55Z

Could you list a few runs that have failed for me to investigate?

In general, my experience has been to the contrary. Self hosted need recurring maintenance and updates which is time consuming. GitHub hosted are managed, which at times breaks because of updates and such but there is always help out there.

Regardless, I will be sure to see what I can do to make the builds more reliable.

parrt · 2022-08-13T21:11:47Z

Hi. All pass but php. The php run just failed again due to timeout:

https://github.com/antlr/antlr4/runs/7821060959?check_suite_focus=true

Run stCarolas/setup-maven@v4.4
  with:
    maven-version: 3.5.4
  env:
    JAVA_HOME: /Users/runner/hostedtoolcache/Java_Zulu_jdk/11.0.16-8/x64
downloading https://archive.apache.org/dist/maven/maven-3/3.5.4/binaries/apache-maven-3.5.4-bin.tar.gz
Error: connect ETIMEDOUT 138.[2](https://github.com/antlr/antlr4/runs/7821060959?check_suite_focus=true#step:5:2)01.1[3](https://github.com/antlr/antlr4/runs/7821060959?check_suite_focus=true#step:5:3)1.13[4](https://github.com/antlr/antlr4/runs/7821060959?check_suite_focus=true#step:5:4):443

parrt · 2022-08-13T21:12:42Z

Trying to rerun failed: https://github.com/antlr/antlr4/actions/runs/2852943941

hs-apotell · 2022-08-13T21:45:04Z

The timeout issue is fixable. The current workflow doesn't cache the dependencies yet. Here's an action that can be incorporated so the builds don't reach out to remote server for dependencies. I will incorporate this and will submit a PR.

https://github.com/actions/cache

parrt · 2022-08-13T22:00:59Z

It looks like the time out did not happen upon rerunning it. I'm going to turn off the remote actions as it looks like we are good to go with hosted.

hs-apotell · 2022-08-13T22:39:14Z

I am not sure what your criteria is for judging the reliability of the builds on Github hosted vs. self-hosted, so I can't really comment on it. Not a single build has succeeded in last 20 days - whether hosted or otherwise. I checked nearly 40 builds on dev branch in last 20 days and most failures are the typical network timeout for Github hosted. For self-hosted, some of the runtimes that are supported are not even being checked (Java and dart are disabled, cpp isn't even included, go has been consistently failing).

Network timeout issue is fixable - remote sites tend to block multiple requests from the same IP to avoid spamming and other attacks. This is a well understood problem and has proven solutions that work.

My personal experience says otherwise, but If you feel self-hosted builds are more reliable and is the way forward, please do so.

parrt · 2022-08-13T22:41:04Z

I'm saying the opposite and agreeing with you. :) I have turned off the remote and left the hosted running, which only fail due to time out at the moment. Maybe I should say self hosted instead of remote.

hs-apotell · 2022-08-13T22:44:45Z

Your use of term 'remote' was confusing. Let's just stick to the official terminology of Github hosted and self-hosted.

I will post a PR with the cache action to avoid the network issue shortly.

parrt · 2022-08-13T22:47:20Z

Sounds good. Sorry for the confusion. self-hosted vs hosted / github-hosted. Thanks for the assist.

hs-apotell · 2022-08-14T06:39:03Z

PR #3820

Please promote the workflow changes to master as well. Empty workflow is failing on master.

parrt · 2022-08-14T17:14:39Z

Done.

parrt · 2022-08-14T17:47:12Z

@hs-apotell looks like we might have issues with master: https://github.com/antlr/antlr4/runs/7828046200?check_suite_focus=true

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\bin\clang.exe
clang: error: unknown argument '-version'; did you mean '--version'?

hs-apotell · 2022-08-15T05:47:21Z

Ahh there are other changes that will have to come to master for the builds to succeed here. Master & dev have digressed too far. The reported issues in the build failures are all fixed in dev.

Is a release due any time soon? If yes, then I would leave master as is and let the merge take care of it. If not, then I can disable the failing builds for master. Fixing those builds in master alone would be throw away work since it's going to get overwritten by dev anyways.

Alternatively, you could just leave it as is and let the future merge take care of it. The workflow was failing before the merge and will continue to fail still, but just for different reasons. The hope was that the merge would get the master builds to succeed but that won't happen unless all the other relevant changes are also merged.

P.S. I don't pay attention to this repository on a regular basis so if there's something that needs my attention in context to CI builds, please file a bug and assign it to me.

parrt · 2022-08-15T16:40:33Z

Ok, sounds good.

hs-apotell mentioned this pull request Jul 16, 2022

[Infra] Check builds for runtime #3783

Closed

parrt added type:improvement comp:build cross-platform-issue comp:testing labels Jul 16, 2022

parrt added this to the 4.10.2 milestone Jul 16, 2022

parrt merged commit 88b8e76 into antlr:dev Jul 16, 2022

KvanTTT reviewed Jul 16, 2022

View reviewed changes

hs-apotell mentioned this pull request Jul 17, 2022

Issue #3783: Fix CI check builds for windows platform #3785

Closed

hs-apotell deleted the hostedci branch July 17, 2022 06:52

parrt mentioned this pull request Aug 13, 2022

Rm remote actions #3819

Merged

admin-token-bot mentioned this pull request Jul 7, 2024

[Snyk] Upgrade antlr4 from 4.7.2 to 4.13.1 mongodb-js/compass#6001

Open

ThatGhostToast mentioned this pull request Nov 7, 2024

[Snyk] Upgrade antlr4 from 4.8.0 to 4.13.2 NextechSystems/fhirpath.js#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #3783: CI Check Builds #3792

Issue #3783: CI Check Builds #3792

hs-apotell commented Jul 16, 2022

ericvergnaud commented Jul 16, 2022

ericvergnaud commented Jul 16, 2022

parrt commented Jul 16, 2022

parrt commented Jul 16, 2022

KvanTTT left a comment

KvanTTT Jul 16, 2022

hs-apotell Jul 23, 2022

KvanTTT commented Jul 16, 2022

hs-apotell commented Jul 16, 2022

parrt commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022 •

edited

Loading

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022 •

edited

Loading

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 14, 2022

parrt commented Aug 14, 2022

parrt commented Aug 14, 2022 •

edited

Loading

hs-apotell commented Aug 15, 2022

parrt commented Aug 15, 2022

Issue #3783: CI Check Builds #3792

Issue #3783: CI Check Builds #3792

Conversation

hs-apotell commented Jul 16, 2022

ericvergnaud commented Jul 16, 2022

ericvergnaud commented Jul 16, 2022

parrt commented Jul 16, 2022

parrt commented Jul 16, 2022

KvanTTT left a comment

Choose a reason for hiding this comment

KvanTTT Jul 16, 2022

Choose a reason for hiding this comment

hs-apotell Jul 23, 2022

Choose a reason for hiding this comment

KvanTTT commented Jul 16, 2022

hs-apotell commented Jul 16, 2022

parrt commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022 • edited Loading

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022 • edited Loading

hs-apotell commented Aug 13, 2022

parrt commented Aug 13, 2022

hs-apotell commented Aug 14, 2022

parrt commented Aug 14, 2022

parrt commented Aug 14, 2022 • edited Loading

hs-apotell commented Aug 15, 2022

parrt commented Aug 15, 2022

parrt commented Aug 13, 2022 •

edited

Loading

parrt commented Aug 13, 2022 •

edited

Loading

parrt commented Aug 14, 2022 •

edited

Loading