Generate meaningful exception message on checkVersion() failure #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, loading a parser from an incompatible version results in a message like: Could not deserialize ATN with version (expected 4). (see e.g. #4041 ) Change the exception message generation to use ord(version), so it shows e.g. the string 3 instead of the character with ordinal 3, which is non-printable and the cause for the above cryptic message. Signed-off-by: Raffaello D. Di Napoli <rafdev@dinapo.li>
ericvergnaud
approved these changes
Feb 7, 2024
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, loading a parser from an incompatible version results in a message like:
(see e.g. #4041 )
Change the exception message generation to use
ord(version), so it shows e.g. the string 3 instead of the character with ordinal 3, which is non-printable and the cause for the above cryptic message.