fix(JS: ErrorListener types) #4731
Merged
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
requested changes
Nov 18, 2024
runtime/JavaScript/src/antlr4/error/DiagnosticErrorListener.d.ts
Outdated
Show resolved
Hide resolved
ericvergnaud
requested changes
Nov 18, 2024
runtime/JavaScript/src/antlr4/error/DiagnosticErrorListener.d.ts
Outdated
Show resolved
Hide resolved
|
@ericvergnaud I addressed your comments, please let me know if this is ok. Thanks! |
|
Looks ok, thanks! But you also need to sign the DCO, see instructions here https://github.com/antlr/antlr4/pull/4731/checks?check_run_id=33170292912 |
added 3 commits
November 19, 2024 12:45
Signed-off-by: Francisco Rodriguez Elorza <francisco.rodriguez.elorza@oracle.com>
Signed-off-by: Francisco Rodriguez Elorza <francisco.rodriguez.elorza@oracle.com>
Signed-off-by: Francisco Rodriguez Elorza <francisco.rodriguez.elorza@oracle.com>
done! Thanks @ericvergnaud ! |
|
Hi @ericvergnaud can you merge it 🙏 ? Thanks! |
Only Terence merges code, we'll have to wait a bit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4730
Updates TypeScript declaration file for
ErrorListener. Additionally updatesDiagnosticErrorListenerthat implementsErrorListenerand adds a declaration file forBitSetclass (BitSet.d.ts).