-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php] examples/strings.php has a BOM--files cannot have BOM!! #4038
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The templates for testing do not consider BOM in a file input. All files cannot have BOM. php/examples/strings.php contains a BOM. For TypeScript, the file is opened and read via readFileSync() into a string. That should have gotten rid of the BOM but it does not. The encoding parameter is "utf-8", but it does not automatically handle BOM. Instead, it considers it as a character. What a lovely language TypeScript/JavaScript is----NOT!!!
I can fix this file, but for future problems, the templates need to cut this BS out. NO BOM!!!!
https://stackoverflow.com/questions/33977843/how-to-detect-if-a-file-has-a-utf-8-bom-in-bash
The text was updated successfully, but these errors were encountered: