Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glsl] Two top-level grammars specified #4248

Open
kaby76 opened this issue Sep 18, 2024 · 2 comments
Open

[glsl] Two top-level grammars specified #4248

kaby76 opened this issue Sep 18, 2024 · 2 comments
Labels

Comments

@kaby76
Copy link
Contributor

kaby76 commented Sep 18, 2024

In the latest version of trgen, a grammar that has two or more top-level grammars cannot work without specifying in the desc.xml to pick one.

In glsl, there is a parser grammar and a parser grammar for a preprocessor. At the moment, the tester cannot pipeline parsers together, i.e., take output of preprocessor and pass to post-preprocessor parser. The desc.xml must specify <grammar-name>GLSL</grammar-name>.

@msagca
Copy link
Contributor

msagca commented Sep 18, 2024

The same is true for the Verilog and SystemVerilog grammars. I had created a pull request (#3353) to address this issue following our conversation (#3348). It's been marked as draft for a long time. Should I specify one grammar name in the desc.xml for these three grammars and be done with it? (Edit: desc.xml of the Verilog grammars look OK)

@kaby76
Copy link
Contributor Author

kaby76 commented Sep 18, 2024

Yes the desc.xml should be updated. But I am still not quite ready with kaby76/Trash#486 and #4246. They fix a number of problems but antlr 4.13.2 broke python3_12_1.

msagca added a commit to msagca/grammars-v4 that referenced this issue Sep 18, 2024
@KvanTTT KvanTTT added the glsl label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants