Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake - alt cast #3929

Merged
merged 2 commits into from
Jan 23, 2024
Merged

snowflake - alt cast #3929

merged 2 commits into from
Jan 23, 2024

Conversation

mlorek
Copy link
Contributor

@mlorek mlorek commented Jan 15, 2024

No description provided.

@mlorek
Copy link
Contributor Author

mlorek commented Jan 15, 2024

HNY! @kaby76 can you assist with the following?

image

@kaby76
Copy link
Contributor

kaby76 commented Jan 15, 2024

The problem is it took too long. There's a 5 minute time out. https://github.com/antlr/grammars-v4/actions/runs/7533854521/job/20507172652#step:24:152

The easiest thing to do is to just yank the target from the desc.xml <targets>.

<targets>CSharp;Cpp;Dart;Java;JavaScript;Python3</targets>

The build script captures the output here.

get-content "tests.txt" | dotnet trwdog -- python3 Test.py -q -x -tee -tree *> parse.txt

But, it should output parse.txt somewhere, and that's probably getting not done.

@mlorek
Copy link
Contributor Author

mlorek commented Jan 16, 2024

The problem is it took too long. There's a 5 minute time out. https://github.com/antlr/grammars-v4/actions/runs/7533854521/job/20507172652#step:24:152

The easiest thing to do is to just yank the target from the desc.xml <targets>.

<targets>CSharp;Cpp;Dart;Java;JavaScript;Python3</targets>

The build script captures the output here.

get-content "tests.txt" | dotnet trwdog -- python3 Test.py -q -x -tee -tree *> parse.txt

But, it should output parse.txt somewhere, and that's probably getting not done.

thanks for checking!
can the timeout be controlled per target?

@mlorek mlorek marked this pull request as ready for review January 16, 2024 08:01
@teverett
Copy link
Member

Is this good to merge?

@kaby76
Copy link
Contributor

kaby76 commented Jan 22, 2024

@teverett Yes, it's good to go.

can the timeout be controlled per target?

Sorry, it can't. But, you can create a subset of the test inputs. E.g.,

<?xml version="1.0" encoding="UTF-8" ?>
<desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../_scripts/desc.xsd">
   <antlr-version>^4.10</antlr-version>
   <targets>CSharp;Cpp;Dart;Go;Java;JavaScript;PHP;Python3;TypeScript</targets>
   <test>
      <name>fast</name>
      <targets>CSharp;Cpp;Dart;Java;JavaScript</targets>
      <inputs>examples</inputs>
   </test>
    <test>
      <name>slow</name>
      <targets>PHP;Python3;TypeScript</targets>
      <inputs>examples/c*.sql</inputs>
   </test>
</desc>

But, the TypeScript target for the grammar doesn't work for some reason.

@teverett
Copy link
Member

@mlorek thanks!

@teverett teverett merged commit 85de28c into antlr:master Jan 23, 2024
18 checks passed
@mlorek mlorek deleted the sf-cast-alt branch February 8, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants