[build] Add testing for grammar ambiguity. #4276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really excited about this one!!
This change adds testing for grammar ambiguity using trperf. The tool essentially runs the parser with the ProfilingATNSimulator. (It does not test the grammar using Z3/SMT. I am still working on that.)
grep
for non-zero ambiguity, then the list of rule names sorted and made unique. It's all done via the command line, using simple Bash piping.The output is a little hard to read, but you can see the list of symbols that are ambiguous after all parses.
The entire list of grammars and ambiguity at this point are here:
ambig.txt
Note, the actual ambiguous parse trees can be obtained using
trparse --ambig
, but that can take a lot of time, so it is not done.