-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyaf 5.0 Final Touch 8 : Use an Optimal Choice Rule for the Quantization Signal transform #239
Comments
Optimal choice Detail : |
The new options parameter will server as a maximum for the number of bins (user-controllable).
The optimal rule can give smaller values. The max will be 20 by default. |
Significant speedup : The number of threads used for quantization will go from 3 to 1. |
antoinecarme
added a commit
that referenced
this issue
Apr 4, 2023
antoinecarme
added a commit
that referenced
this issue
Apr 4, 2023
…e an Optimal Choice Rule for the Quantization Signal transform #239. Updated these logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When performing signal quantization, PyAF uses a set of bin numbers (Q=5, 10, 20). This is too slow. Use an optimal bin number selection rule (square root, diaconis, etc).
pyaf/pyaf/TS/Options.py
Line 202 in 4ab4a65
An easy rule for variable bin width, equi-frequency, is this one :
https://en.wikipedia.org/wiki/Histogram#Variable_bin_widths
The user choice, of course, will override this setting.
This issue only impacts slow modeling processes. Will not have impact by default.
The text was updated successfully, but these errors were encountered: