Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primitives): Remove Attributes Module #510

Closed
refcell opened this issue Sep 6, 2024 · 0 comments · Fixed by #529
Closed

fix(primitives): Remove Attributes Module #510

refcell opened this issue Sep 6, 2024 · 0 comments · Fixed by #529

Comments

@refcell
Copy link
Collaborator

refcell commented Sep 6, 2024

Description

The attributes module in kona-primitives contains two core types to upstream into op-alloy-rpc-types-engine.

  • L2PayloadAttributes
  • L2AttributesWithParent

op-alloy-rpc-types-engine already defines a OptimismPayloadAttributes that should serve as a drop-in replacement for L2PayloadAttributes, but L2AttributesWithParent will need to be upstreamed to op-alloy-rpc-types-engine.

Additionally, the op-alloy-rpc-types-engine should be made optionally serde, enabling the feature by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(primitives): Remove Attributes anton-rs/kona
1 participant
@refcell